[Mesa-dev] [PATCH] mesa/program: change validate_inputs() local var 'inputs' to GLbitfield64

[Nicolai Hähnle]

On 17.01.2018 06:18, Brian Paul wrote:
> Both state->prog->info.inputs_read and state->InputsBound are GLbitfield64
> so it seems that the OR of those values should be of the same type.
> I'm not sure this fixes any actual issues though.

It's certainly less surprising this way.

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

> ---
>   src/mesa/program/program_parse.y | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y
> index 04ec18d..1bc5f51 100644
> --- a/src/mesa/program/program_parse.y
> +++ b/src/mesa/program/program_parse.y
> @@ -2212,7 +2212,7 @@ set_src_reg_swz(struct asm_src_register *r, gl_register_file file, GLint index,
>   int
>   validate_inputs(struct YYLTYPE *locp, struct asm_parser_state *state)
>   {
> -   const GLbitfield inputs = state->prog->info.inputs_read | state->InputsBound;
> +   const GLbitfield64 inputs = state->prog->info.inputs_read | state->InputsBound;
>      GLbitfield ff_inputs = 0;
>   
>      /* Since Mesa internal attribute indices are different from
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.