[Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

Dylan Baker dylan at pnwbakers.com
Thu Jan 18 17:13:13 UTC 2018


I'm not sure how Emil feels about this (and the related patches) but I think it
might be better to handle this at the build system level, for meson it would
look something like (in the top level meson.build):

if cc.get_define('ETIME') == ''
  pre_args += '-DETIME=ETIMEDOUT'
endif

Which should be a permanent fix. Emil can probably provide an autotools
equivalent.

Quoting Greg V (2017-12-31 08:55:16)
> FreeBSD only has ETIMEDOUT, not ETIME
> ---
>  src/gallium/drivers/vc4/vc4_bufmgr.c | 4 ++++
>  src/gallium/drivers/vc5/vc5_bufmgr.c | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/src/gallium/drivers/vc4/vc4_bufmgr.c b/src/gallium/drivers/vc4/vc4_bufmgr.c
> index 274c4c3120..cbc1e1ae1b 100644
> --- a/src/gallium/drivers/vc4/vc4_bufmgr.c
> +++ b/src/gallium/drivers/vc4/vc4_bufmgr.c
> @@ -35,6 +35,10 @@
>  #include "vc4_context.h"
>  #include "vc4_screen.h"
>  
> +#ifndef ETIME
> +#define ETIME ETIMEDOUT
> +#endif
> +
>  #ifdef HAVE_VALGRIND
>  #include <valgrind.h>
>  #include <memcheck.h>
> diff --git a/src/gallium/drivers/vc5/vc5_bufmgr.c b/src/gallium/drivers/vc5/vc5_bufmgr.c
> index c6c06dcfda..b676373689 100644
> --- a/src/gallium/drivers/vc5/vc5_bufmgr.c
> +++ b/src/gallium/drivers/vc5/vc5_bufmgr.c
> @@ -35,6 +35,10 @@
>  #include "vc5_context.h"
>  #include "vc5_screen.h"
>  
> +#ifndef ETIME
> +#define ETIME ETIMEDOUT
> +#endif
> +
>  #ifdef HAVE_VALGRIND
>  #include <valgrind.h>
>  #include <memcheck.h>
> -- 
> 2.15.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180118/4a819d0b/attachment.sig>


More information about the mesa-dev mailing list