[Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

[Roland Scheidegger]

Looks good to me, seems like you're nearly done with gl 4.5 ;-)

Reviewed-by: Roland Scheidegger <sroland at vmware.com>

Am 18.01.2018 um 05:11 schrieb Dave Airlie:
> From: Dave Airlie <airlied at redhat.com>
> 
> Only one piglit test fails,
> sso-vs-gs-fs-array-interleave
> 
> There are 3 tests using ssbo without checking sizes failing also
> but those are test bugs.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  docs/features.txt                    | 4 ++--
>  docs/relnotes/17.4.0.html            | 1 +
>  src/gallium/drivers/r600/r600_pipe.c | 2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/features.txt b/docs/features.txt
> index e9b7be5..4b2bf2c 100644
> --- a/docs/features.txt
> +++ b/docs/features.txt
> @@ -193,11 +193,11 @@ GL 4.4, GLSL 4.40 -- all DONE: i965/gen8+, nvc0, radeonsi
>    GL_MAX_VERTEX_ATTRIB_STRIDE                           DONE (all drivers)
>    GL_ARB_buffer_storage                                 DONE (freedreno, i965, nv50, r600, llvmpipe, swr)
>    GL_ARB_clear_texture                                  DONE (i965, nv50, r600, llvmpipe, softpipe, swr)
> -  GL_ARB_enhanced_layouts                               DONE (i965, nv50, llvmpipe, softpipe)
> +  GL_ARB_enhanced_layouts                               DONE (i965, nv50, r600, llvmpipe, softpipe)
>    - compile-time constant expressions                   DONE
>    - explicit byte offsets for blocks                    DONE
>    - forced alignment within blocks                      DONE
> -  - specified vec4-slot component numbers               DONE (i965, nv50, llvmpipe, softpipe)
> +  - specified vec4-slot component numbers               DONE
>    - specified transform/feedback layout                 DONE
>    - input/output block locations                        DONE
>    GL_ARB_multi_bind                                     DONE (all drivers)
> diff --git a/docs/relnotes/17.4.0.html b/docs/relnotes/17.4.0.html
> index 1adbb3e..412c0fc 100644
> --- a/docs/relnotes/17.4.0.html
> +++ b/docs/relnotes/17.4.0.html
> @@ -50,6 +50,7 @@ Note: some of the new features are only available with certain drivers.
>  <li>GL_ARB_shader_storage_buffer_object on r600/evergreen+<li>
>  <li>GL_ARB_compute_shader on r600/evergreen+<li>
>  <li>GL_ARB_cull_distance on r600/evergreen+</li>
> +<li>GL_ARB_enhanced_layouts on r600/evergreen+</li>
>  <li>GL_ARB_bindless_texture on nvc0/kepler</li>
>  <li>OpenGL 4.3 on r600/evergreen with hw fp64 support</li>
>  <li>Support 1 binary format for GL_ARB_get_program_binary on i965</li>
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index c146383..e7f8ae8 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -351,6 +351,7 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>  	case PIPE_CAP_SAMPLER_VIEW_TARGET:
>  	case PIPE_CAP_TGSI_PACK_HALF_FLOAT:
>  	case PIPE_CAP_TGSI_CLOCK:
> +	case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>  		return family >= CHIP_CEDAR ? 1 : 0;
>  	case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
>  		return family >= CHIP_CEDAR ? 4 : 0;
> @@ -387,7 +388,6 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>  	case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>  	case PIPE_CAP_TGSI_VOTE:
>  	case PIPE_CAP_MAX_WINDOW_RECTANGLES:
> -	case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>  	case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>  	case PIPE_CAP_NATIVE_FENCE_FD:
>  	case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>