[Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

Emil Velikov emil.l.velikov at gmail.com
Thu Jan 18 18:40:40 UTC 2018


On 18 January 2018 at 17:13, Dylan Baker <dylan at pnwbakers.com> wrote:
> I'm not sure how Emil feels about this (and the related patches) but I think it
> might be better to handle this at the build system level, for meson it would
> look something like (in the top level meson.build):
>
> if cc.get_define('ETIME') == ''
>   pre_args += '-DETIME=ETIMEDOUT'
> endif
>
> Which should be a permanent fix. Emil can probably provide an autotools
> equivalent.
>
I'm not sure how the above works on meson - the define can come from
multiple places.
Surely meson does not check every header available on the system?

FWIW I've spent hours over the years looking at this ETIME workaround.
Due to $reasons various projects define the macro, some even without
checking if it's already set.
Memory is fuzzy, but I believe I've seen projects installing headers
with the redefine.

I sincerely hope that the FreeBSD devs can see waste of time this is
causing them and consider a more pragmatic solution.

-Emil


More information about the mesa-dev mailing list