[Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

[Dylan Baker]

Quoting Emil Velikov (2018-01-18 10:40:40)
> On 18 January 2018 at 17:13, Dylan Baker <dylan at pnwbakers.com> wrote:
> > I'm not sure how Emil feels about this (and the related patches) but I think it
> > might be better to handle this at the build system level, for meson it would
> > look something like (in the top level meson.build):
> >
> > if cc.get_define('ETIME') == ''
> >   pre_args += '-DETIME=ETIMEDOUT'
> > endif
> >
> > Which should be a permanent fix. Emil can probably provide an autotools
> > equivalent.
> >
> I'm not sure how the above works on meson - the define can come from
> multiple places.
> Surely meson does not check every header available on the system?

It doesn't, it checks for defines the preprocessor knows about, if you need to
check specific headers there's `has_header_symbol`.

Maybe this isn't feasible, but it really feels like having to define ETIME all
over the tree if it's not defined is fragile and ugly. I'm with you and Eric
that FreeBSD really should solve this themselves.

> 
> FWIW I've spent hours over the years looking at this ETIME workaround.
> Due to $reasons various projects define the macro, some even without
> checking if it's already set.
> Memory is fuzzy, but I believe I've seen projects installing headers
> with the redefine.
> 
> I sincerely hope that the FreeBSD devs can see waste of time this is
> causing them and consider a more pragmatic solution.
> 
> -Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180118/28876246/attachment-0001.sig>