[Mesa-dev] [PATCH 2/2] radv: Replace an assert with unreachable.

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jan 18 21:10:18 UTC 2018


Series is:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 01/17/2018 11:25 PM, Bas Nieuwenhuizen wrote:
> Otherwise we get uninitialized variable warnings for es_vgpr_comp_cnt.
> ---
>   src/amd/vulkan/radv_shader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index 9819a522d7..3bcaac168a 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -424,7 +424,7 @@ radv_fill_shader_variant(struct radv_device *device,
>   		} else if (es_type == MESA_SHADER_TESS_EVAL) {
>   			es_vgpr_comp_cnt = 3;
>   		} else {
> -			assert(!"invalid shader ES type");
> +			unreachable("invalid shader ES type");
>   		}
>   
>   		/* If offsets 4, 5 are used, GS_VGPR_COMP_CNT is ignored and
> 


More information about the mesa-dev mailing list