[Mesa-dev] [PATCH v2 0/4] Fix unm_sampes and some warnings

[Gert Wollny]

Am Donnerstag, den 18.01.2018, 14:15 -0800 schrieb Ian Romanick:
> Patches 2, 3, and 4 are
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> 
Thanks, 

I send out a lot of patches that fix warnings.  I like to copy-and-
paste the warnings that are eliminated into the commit message.  It's
not required, but I feel like it helps.  The only trick is to make
sure the console you copy from is 80-columns. :)

Good idea, I'll keep that in mind for the next time. 

best, 
Gert 

> 
> On 01/18/2018 12:57 AM, Gert Wollny wrote:
> > with the pointers that Emil gave me I prepared a second version of 
> > the series:  
> > 
> > Changes in v2: 
> > 
> > Patch 1: 
> > * split the first patch into gallium and mesa part (as suggested) 
> > * also correct the according parameter of st_new_renderbuffer_fb 
> > Patch 2 & 3 (now 3 & 4) 
> > * instead of annotating the unused parameter I remove it (as
> > suggested)
> >   since these patches now touch more files I kept them separate, 
> > 
> > Many thanks, 
> > Gert
> > --
> > 
> > Gert Wollny (4):
> >   gallium: Make (num_)samples an unsigned int (part 1)
> >   mesa: Make numSamples an unsigned int (part 2)
> >   mesa/program/prog_execute.c: Silence -Wunused-param
> >   mesa/program: Fix -Wunused-param warning
> > 
> >  src/gallium/include/state_tracker/st_api.h    | 2 +-
> >  src/gallium/state_trackers/glx/xlib/glx_api.c | 8 ++++++--
> >  src/mesa/main/context.c                       | 4 ++--
> >  src/mesa/main/context.h                       | 4 ++--
> >  src/mesa/main/mtypes.h                        | 2 +-
> >  src/mesa/main/multisample.c                   | 2 +-
> >  src/mesa/program/arbprogparse.c               | 2 +-
> >  src/mesa/program/ir_to_mesa.cpp               | 2 +-
> >  src/mesa/program/prog_execute.c               | 9 +++------
> >  src/mesa/program/prog_optimize.c              | 3 +--
> >  src/mesa/program/prog_optimize.h              | 3 +--
> >  src/mesa/state_tracker/st_cb_fbo.c            | 2 +-
> >  src/mesa/state_tracker/st_cb_fbo.h            | 2 +-
> >  13 files changed, 22 insertions(+), 23 deletions(-)