[Mesa-dev] [PATCH] radv: Don't allow 3d or 1d depth/stencil textures.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Sun Jan 21 22:43:25 UTC 2018


addrlib asserts when that happens, and supporting it is not
required so lets not allow this for now.

It also assert on fmask, but we don't have the number of samples here.

CC: <mesa-stable at lists.freedesktop.org>
---
 src/amd/vulkan/radv_formats.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index c008c1bae6..19cd2b1a91 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -1063,6 +1063,9 @@ static VkResult radv_get_image_format_properties(struct radv_physical_device *ph
 	if (format_feature_flags == 0)
 		goto unsupported;
 
+	if (info->type != VK_IMAGE_TYPE_2D && vk_format_is_depth_or_stencil(info->format))
+		goto unsupported;
+
 	switch (info->type) {
 	default:
 		unreachable("bad vkimage type\n");
-- 
2.15.1



More information about the mesa-dev mailing list