[Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

[Jason Ekstrand]

Fair enough.  I wasn't sure what you meant.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


On January 21, 2018 08:02:44 Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 19 January 2018 at 16:17, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> Why?  I think it's probably fine but changing signedness of a variable is
>> always a bit tricky.
>>
> As said in the commit message - all the call sites already consider it
> as unsigned.
> Quick grep shows:
>
> brw_state_upload.c:
>    const unsigned fb_samples = ...
>    if (brw->num_samples != fb_samples)
>       brw->num_samples = fb_samples
>
> genX_state_upload.c:
>    unsigned num_samples = brw->num_samples;
>
> and the same thing for emit_3dstate_multisample2.
>
> Furthermore the data is propagated from the common code, where it is
> also unsigned.
>
> -Emil