[Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

[Roland Scheidegger]

Am 22.01.2018 um 08:16 schrieb Tapani Pälli:
> 
> 
> On 01/22/2018 08:48 AM, Ilia Mirkin wrote:
>> What es3 does require, though, is mrt. Maybe add something that
>> ensures that mrt is supported?
> 
> I guess that would be EXT_draw_buffers? That is currently enabled with
> 'dummy_true'.
But only because it allows a dummy implementation - minimum of
MaxDrawBuffers allowed is 1 as per the extension spec.
GLES 3.0-3.2 would require 4, GL 3.0-4.6 would require 8 at a quick
glance...
I guess adding a check wouldn't hurt, but I suppose all drivers
currently exposing the affected gl/gles versions would already meet the
limit.

Roland

> 
> 
>> On Jan 19, 2018 08:39, "Eric Anholt" <eric at anholt.net
>> <mailto:eric at anholt.net>> wrote:
>>
>>     We've been requiring this since GLES 3.0 was introduced, but the
>>     GLES 3.2
>>     spec is the one that has "Supporting blending on a per-draw-buffer
>>     basis"
>>     in the new features.  V3D 3.3 would require lowering blending to
>> shader
>>     code to implement independent blending.
>>     ---
>>       src/mesa/main/version.c | 2 +-
>>       1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>     diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
>>     index 68079f4ebbba..1fce8fe7ca9c 100644
>>     --- a/src/mesa/main/version.c
>>     +++ b/src/mesa/main/version.c
>>     @@ -516,7 +516,6 @@ compute_version_es2(const struct gl_extensions
>>     *extensions,
>>                                extensions->ARB_texture_float &&
>>                                extensions->ARB_texture_rg &&
>>                                extensions->ARB_depth_buffer_float &&
>>     -                         extensions->EXT_draw_buffers2 &&
>>                                /* extensions->ARB_framebuffer_object
>> && */
>>                                extensions->EXT_framebuffer_sRGB &&
>>                                extensions->EXT_packed_float &&
>>     @@ -546,6 +545,7 @@ compute_version_es2(const struct gl_extensions
>>     *extensions,
>>                                extensions->ARB_gpu_shader5 &&
>>                                extensions->EXT_shader_integer_mix);
>>          const bool ver_3_2 = (ver_3_1 &&
>>     +                         extensions->EXT_draw_buffers2 &&
>>                                extensions->KHR_blend_equation_advanced &&
>>                                extensions->KHR_robustness &&
>>                                  
>> extensions->KHR_texture_compression_astc_ldr &&
>>     --
>>     2.15.0
>>
>>     _______________________________________________
>>     mesa-dev mailing list
>>     mesa-dev at lists.freedesktop.org
>> <mailto:mesa-dev at lists.freedesktop.org>
>>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
>>
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev