[Mesa-dev] [PATCH 1/3] intel: add new common header gen_defines.h

[Tapani Pälli]

On 22.01.2018 17:10, Emil Velikov wrote:
> On 22 January 2018 at 12:29, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>   src/intel/common/gen_defines.h | 52 ++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 52 insertions(+)
>>   create mode 100644 src/intel/common/gen_defines.h
>>
> Please add the file to the src/intel/Makefile.sources COMMON_FILES list.

ok

> 
>> diff --git a/src/intel/common/gen_defines.h b/src/intel/common/gen_defines.h
>> new file mode 100644
>> index 0000000000..f8daa84431
>> --- /dev/null
>> +++ b/src/intel/common/gen_defines.h
>> @@ -0,0 +1,52 @@
>> +/*
>> + * Copyright © 2018 Intel Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> + * a copy of this software and associated documentation files (the
>> + * "Software"), to deal in the Software without restriction, including
>> + * without limitation the rights to use, copy, modify, merge, publish,
>> + * distribute, sublicense, and/or sell copies of the Software, and to
>> + * permit persons to whom the Software is furnished to do so, subject to
>> + * the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the
>> + * next paragraph) shall be included in all copies or substantial
>> + * portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
>> + * IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
>> + * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
>> + * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
>> + * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +#ifndef GEN_DEFINES_H
>> +#define GEN_DEFINES_H
>> +
> #include "i915_drm.h"
> 
> ^^ is where the I915_CONTEXT*PRIORITY symbols are defined, so let's
> include that.

Will do, thanks Emil!

> With the two nitpicks, the series is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil
> 

// Tapani