[Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

[Chuck Atkins]

Hi Emil,

Please include your follow-up reply/context as commit message.
>

Will do.


> +// cleanup for failed screen creation
> > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen);
>
> I'm fairly sure you don't need to make this function public. It's used
> within the same binary - libmesaswr.la. Regardless if built-in or
> separate DSO's are used.
>

You are, of course, correct.  I was conflating static with not public and
thinking that since it's not in the same translation unit then it can't be
static so it must be public, which is certainly not the case.


With the above two suggestions:
>
> Cc: mesa-stable at lists.freedesktop.org


I purposely left this out of mesa-stable since it requires the previous two
commits that initially refactored swr_create_screen to allow for builtin
arch, which were not part of stable.

- Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180122/1a884b79/attachment.html>