[Mesa-dev] [PATCH v3 06/24] anv/image: Add a helper for determining when fast clears are supported

[Nanley Chery]

On Mon, Jan 22, 2018 at 12:19:33AM -0800, Jason Ekstrand wrote:
> v2 (Jason Ekstrand):
>  - Return an enum instead of a boolean
> 
> v3 (Jason Ekstrand):
>  - Return ANV_FAST_CLEAR_NONE instead of false (Topi)
>  - Rename ANV_FAST_CLEAR_ANY to ANV_FAST_CLEAR_DEFAULT_VALUE
>  - Add documentation for the enum values
> 
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/intel/vulkan/anv_image.c   | 71 ++++++++++++++++++++++++++++++++++++++++++
>  src/intel/vulkan/anv_private.h | 16 ++++++++++
>  2 files changed, 87 insertions(+)
> 
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index 0aa8cd9..4cd4fe1 100644
> --- a/src/intel/vulkan/anv_image.c
> +++ b/src/intel/vulkan/anv_image.c
> @@ -861,6 +861,77 @@ anv_layout_to_aux_usage(const struct gen_device_info * const devinfo,
>     unreachable("layout is not a VkImageLayout enumeration member.");
>  }
>  
> +/**
> + * This function returns the level of unresolved fast-clear support of the
> + * given image in the given VkImageLayout.
> + *
> + * @param devinfo The device information of the Intel GPU.
> + * @param image The image that may contain a collection of buffers.
> + * @param aspect The aspect of the image to be accessed.
> + * @param layout The current layout of the image aspect(s).
> + */
> +enum anv_fast_clear_type
> +anv_layout_to_fast_clear_type(const struct gen_device_info * const devinfo,
> +                              const struct anv_image * const image,
> +                              const VkImageAspectFlagBits aspect,
> +                              const VkImageLayout layout)
> +{
> +   /* The aspect must be exactly one of the image aspects. */
> +   assert(_mesa_bitcount(aspect) == 1 && (aspect & image->aspects));
> +
> +   uint32_t plane = anv_image_aspect_to_plane(image->aspects, aspect);
> +
> +   /* If there is no auxiliary surface allocated, there are no fast-clears */
> +   if (image->planes[plane].aux_surface.isl.size == 0)
> +      return ANV_FAST_CLEAR_NONE;
> +
> +   /* All images that use an auxiliary surface are required to be tiled. */
> +   assert(image->tiling == VK_IMAGE_TILING_OPTIMAL);
> +
> +   /* Stencil has no aux */
> +   assert(aspect != VK_IMAGE_ASPECT_STENCIL_BIT);
> +
> +   if (aspect == VK_IMAGE_ASPECT_DEPTH_BIT) {
> +      /* For depth images (with HiZ), the layout supports fast-clears if and
> +       * only if it supports HiZ.  However, we only support fast-clears to the
> +       * default depth value.
> +       */
> +      enum isl_aux_usage aux_usage =
> +         anv_layout_to_aux_usage(devinfo, image, aspect, layout);
> +      return aux_usage == ISL_AUX_USAGE_HIZ ?
> +             ANV_FAST_CLEAR_DEFAULT_VALUE : ANV_FAST_CLEAR_NONE;
> +   }
> +
> +   assert(image->aspects & VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV);
> +
> +   /* Multisample fast-clear is not yet supported. */
> +   if (image->samples > 1)
> +      return ANV_FAST_CLEAR_NONE;
> +
> +   /* The only layout which actually supports fast-clears today is
> +    * VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.  Some day in the future
> +    * this may change if our ability to track clear colors improves.
> +    */

With this comment removed, this patch is
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

> +   switch (layout) {
> +   case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL:
> +      return ANV_FAST_CLEAR_ANY;
> +
> +   case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR:
> +      return ANV_FAST_CLEAR_NONE;
> +
> +   default:
> +      /* If the image has CCS_E enabled all the time then we can use
> +       * fast-clear as long as the clear color is the default value of zero
> +       * since this is the default value we program into every surface state
> +       * used for texturing.
> +       */
> +      if (image->planes[plane].aux_usage == ISL_AUX_USAGE_CCS_E)
> +         return ANV_FAST_CLEAR_DEFAULT_VALUE;
> +      else
> +         return ANV_FAST_CLEAR_NONE;
> +   }
> +}
> +
>  
>  static struct anv_state
>  alloc_surface_state(struct anv_device *device)
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index cf82196..b96895b 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -2423,6 +2423,16 @@ struct anv_image {
>     } planes[3];
>  };
>  
> +/* The ordering of this enum is important */
> +enum anv_fast_clear_type {
> +   /** Image does not have/support any fast-clear blocks */
> +   ANV_FAST_CLEAR_NONE = 0,
> +   /** Image has/supports fast-clear but only to the default value */
> +   ANV_FAST_CLEAR_DEFAULT_VALUE = 1,
> +   /** Image has/supports fast-clear with an arbitrary fast-clear value */
> +   ANV_FAST_CLEAR_ANY = 2,
> +};
> +
>  /* Returns the number of auxiliary buffer levels attached to an image. */
>  static inline uint8_t
>  anv_image_aux_levels(const struct anv_image * const image,
> @@ -2545,6 +2555,12 @@ anv_layout_to_aux_usage(const struct gen_device_info * const devinfo,
>                          const VkImageAspectFlagBits aspect,
>                          const VkImageLayout layout);
>  
> +enum anv_fast_clear_type
> +anv_layout_to_fast_clear_type(const struct gen_device_info * const devinfo,
> +                              const struct anv_image * const image,
> +                              const VkImageAspectFlagBits aspect,
> +                              const VkImageLayout layout);
> +
>  /* This is defined as a macro so that it works for both
>   * VkImageSubresourceRange and VkImageSubresourceLayers
>   */
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev