[Mesa-dev] [PATCH] u_thread: Use pthread_setname_np on linux only

Jose Fonseca jfonseca at vmware.com
Mon Jan 22 21:12:54 UTC 2018


On 22/01/18 21:04, Samuel Thibault wrote:
> Hello,
> 
> Jose Fonseca, on lun. 15 janv. 2018 12:29:39 +0000, wrote:
>> On 13/01/18 11:33, Samuel Thibault wrote:
>>> pthread_setname_np was added in glibc 2.12 for the Linux port only, other
>>> ports do not necessarily have it.
>>> ---
>>>    src/util/u_thread.h | 3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/src/util/u_thread.h b/src/util/u_thread.h
>>> index 26cc0b093..8c6e0bdc5 100644
>>> --- a/src/util/u_thread.h
>>> +++ b/src/util/u_thread.h
>>> @@ -62,7 +62,8 @@ static inline void u_thread_setname( const char *name )
>>>    {
>>>    #if defined(HAVE_PTHREAD)
>>>    #  if defined(__GNU_LIBRARY__) && defined(__GLIBC__) && defined(__GLIBC_MINOR__) && \
>>> -      (__GLIBC__ >= 3 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 12))
>>> +      (__GLIBC__ >= 3 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 12)) && \
>>> +      defined(__linux__)
>>>       pthread_setname_np(pthread_self(), name);
>>>    #  endif
>>>    #endif
>>>
>>
>> Looks good to me.
>>
>> Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
> 
> Could somebody commit this?
> 
> Thanks,
> Samuel

Pushed.  Thanks.

Jose



More information about the mesa-dev mailing list