[Mesa-dev] [PATCH] meson: fix some defines misspelled errors in meson.build

[Eric Engestrom]

On Tuesday, 2018-01-23 15:49:43 +0100, Marc Dietrich wrote:
> Defines
> - HAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL
> - HAVE_FUNC_ATTRIBUTE_VISIBILITY
> were misspelled.

Wow, good catch!
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

and pushed :)

Out of curiosity, did you find those by hand, or do you have a tool that
catches defines misspellings like these?
I'm asking because I toyed with the idea of building such a tool, having
not found one online, but I never actually did it.

> 
> Signed-off-by: Marc Dietrich <marvin24 at gmx.de>
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index c95c44641f..9e3b98641f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -682,14 +682,14 @@ if cc.compiles('struct __attribute__((packed)) foo { int bar; };',
>  endif
>  if cc.compiles('int *foo(void) __attribute__((returns_nonnull));',
>                 name : '__attribute__((returns_nonnull))')
> -  pre_args += '-DHAVE_FUNC_ATTRIBUTE_NONNULL'
> +  pre_args += '-DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL'
>  endif
>  if cc.compiles('''int foo_def(void) __attribute__((visibility("default")));
>                    int foo_hid(void) __attribute__((visibility("hidden")));
>                    int foo_int(void) __attribute__((visibility("internal")));
>                    int foo_pro(void) __attribute__((visibility("protected")));''',
>                 name : '__attribute__((visibility(...)))')
> -  pre_args += '-DHAVE_FUNC_ATTRIBUTE_VISBILITY'
> +  pre_args += '-DHAVE_FUNC_ATTRIBUTE_VISIBILITY'
>  endif
>  if cc.compiles('int foo(void) { return 0; } int bar(void) __attribute__((alias("foo")));',
>                 name : '__attribute__((alias(...)))')
> -- 
> 2.16.0
>