[Mesa-dev] [PATCH 04/20] swr/rast: Initial work for debugging support.

[Emil Velikov]

Hi George,

On 19 January 2018 at 21:46, George Kyriazis <george.kyriazis at intel.com> wrote:
> Adds ability to step into jitted llvm IR in Visual Studio.
> - Updated llvm type generation script to also generate corresponding debug types.
> - New module pass inserts debug metadata into the IR for each function
>
> Disabled by default.
> ---

This commit introduces createBasicType() which has varying signature
across LLVM versions.
Leading to build failure with LLVM 3.9 - LLVM 5.0.0 seems to be fine.
Skim through the LLVM repo highlights [1].

NOTE: that this was the first build error that I've spotted and there
could be others.

Can you please fix-up so that things build across all supported LLVM
versions, or simply adjust the versions supported for the builds [2]?
Adding a fixes tag in the fix-up, will make it easier to correlate two commits.

Fixes: 01ab218bbc5 ("swr/rast: Initial work for debugging support.")

As dealing multiple LLVM versions is a pain, we have a few build
combinations for Travis-CI.
There is no automated testing yet, so you can use your github account
to test before submitting/merging patches.
Do tweak the matrix to better fit SWR needs.

You don't have to use Travis, if you have something else at hand.

For now, I'll do 18.0.0-rc1 with a big disclaimer that SWR+LLVM 3.9
builds are broken.

Thanks
Emil

[1] https://github.com/llvm-mirror/llvm/commit/e69c459a6e9756ca1ff3acb1dcfc434843aee80f

[2] The following files will need to be tweaked
configure.ac, LLVM_REQUIRED_SWR
src/gallium/drivers/swr/SConscript
meson.build

[3] https://travis-ci.org/evelikov/Mesa/builds/322358291