[Mesa-dev] [PATCH v2 06/22] clover: Move device extensions definitions to core/device.cpp

[Francisco Jerez]

Pierre Moreau <pierre.morrow at free.fr> writes:

> Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/gallium/state_trackers/clover/api/device.cpp  | 11 +----------
>  src/gallium/state_trackers/clover/core/device.cpp | 14 ++++++++++++++
>  src/gallium/state_trackers/clover/core/device.hpp |  1 +
>  3 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp
> index 576555a9af..4e274c5005 100644
> --- a/src/gallium/state_trackers/clover/api/device.cpp
> +++ b/src/gallium/state_trackers/clover/api/device.cpp
> @@ -330,16 +330,7 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info param,
>        break;
>  
>     case CL_DEVICE_EXTENSIONS:
> -      buf.as_string() =
> -         "cl_khr_byte_addressable_store"
> -         " cl_khr_global_int32_base_atomics"
> -         " cl_khr_global_int32_extended_atomics"
> -         " cl_khr_local_int32_base_atomics"
> -         " cl_khr_local_int32_extended_atomics"
> -         + std::string(dev.has_int64_atomics() ? " cl_khr_int64_base_atomics" : "")
> -         + std::string(dev.has_int64_atomics() ? " cl_khr_int64_extended_atomics" : "")
> -         + std::string(dev.has_doubles() ? " cl_khr_fp64" : "")
> -         + std::string(dev.has_halves() ? " cl_khr_fp16" : "");
> +      buf.as_string() = dev.supported_extensions();
>        break;
>  
>     case CL_DEVICE_PLATFORM:
> diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp
> index 7eaa0ca2cb..9fb233aa72 100644
> --- a/src/gallium/state_trackers/clover/core/device.cpp
> +++ b/src/gallium/state_trackers/clover/core/device.cpp
> @@ -279,3 +279,17 @@ bool
>  device::supports_ir(cl_uint ir) const {
>     return supported_irs() & (1 << ir);
>  }
> +
> +std::string
> +device::supported_extensions() const {
> +   return
> +      "cl_khr_byte_addressable_store"
> +      " cl_khr_global_int32_base_atomics"
> +      " cl_khr_global_int32_extended_atomics"
> +      " cl_khr_local_int32_base_atomics"
> +      " cl_khr_local_int32_extended_atomics"
> +      + std::string(has_int64_atomics() ? " cl_khr_int64_base_atomics" : "")
> +      + std::string(has_int64_atomics() ? " cl_khr_int64_extended_atomics" : "")
> +      + std::string(has_doubles() ? " cl_khr_fp64" : "")
> +      + std::string(has_halves() ? " cl_khr_fp16" : "");
> +}
> diff --git a/src/gallium/state_trackers/clover/core/device.hpp b/src/gallium/state_trackers/clover/core/device.hpp
> index eed644e919..98b9637ace 100644
> --- a/src/gallium/state_trackers/clover/core/device.hpp
> +++ b/src/gallium/state_trackers/clover/core/device.hpp
> @@ -83,6 +83,7 @@ namespace clover {
>        cl_uint supported_irs() const;
>        std::string ir_target() const;
>        enum pipe_endian endianness() const;
> +      std::string supported_extensions() const;
>  
>        bool supports_ir(cl_uint ir) const;
>  
> -- 
> 2.16.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180123/9d0f2964/attachment.sig>