[Mesa-dev] [PATCH] anv_icd.py: improve reproducible builds

[Jason Ekstrand]

Pushed.  Thanks and welcome to Mesa!

--Jason

On Fri, Jan 26, 2018 at 12:56 AM, Maxin B. John <maxin.john at gmail.com>
wrote:

> Hi,
>
> On Thu, Jan 18, 2018 at 3:22 PM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
> > On 18 January 2018 at 11:33,  <maxin.john at gmail.com> wrote:
> >> From: "Maxin B. John" <maxin.john at intel.com>
> >>
> >> Sort the output to ensure build reproducibility
> >>
> >> Signed-off-by: Maxin B. John <maxin.john at intel.com>
> >> ---
> >>  src/intel/vulkan/anv_icd.py | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/intel/vulkan/anv_icd.py b/src/intel/vulkan/anv_icd.py
> >> index 4ed01fa..31bb068 100644
> >> --- a/src/intel/vulkan/anv_icd.py
> >> +++ b/src/intel/vulkan/anv_icd.py
> >> @@ -44,4 +44,4 @@ if __name__ == '__main__':
> >>      }
> >>
> >>      with open(args.out, 'w') as f:
> >> -        json.dump(json_data, f, indent = 4)
> >> +        json.dump(json_data, f, indent = 4, sort_keys=True)
> >
> > I'm slightly confused what exactly causes the issue.
> > Please shed some light so we can add it to the commit message.
> >
> > Regardless, the patch seems correct and is
> >
> > Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> > Fixes: 0ab04ba979b ("anv: Use python to generate ICD json files")
> >
> > -Emil
>
> Gentle ping !
>
> Regards,
> Maxin
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180126/0250d85d/attachment.html>