[Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

[Eric Engestrom]

On January 30, 2018 5:34:07 PM UTC, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Eric Engestrom (2018-01-29 10:15:50)
> > The big comment is taken from the equivalent block in configure.ac
> > 
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> >  meson.build                                 | 30
> +++++++++++++++++++++--------
> >  src/gallium/targets/d3dadapter9/meson.build |  2 +-
> >  src/mesa/drivers/dri/meson.build            |  2 +-
> >  3 files changed, 24 insertions(+), 10 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 0a00798c2a5093ec803b..6d7a8e976ff6ad002d9a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -41,6 +41,20 @@ pre_args = [
> >   
> '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa"',
> >  ]
> >  
> > +# The idea is that libdrm is distributed as one cohesive package,
> even
> > +# though it is composed of multiple libraries. However some drivers
> > +# may have different version requirements than others. This list
> > +# codifies which drivers need which version of libdrm. Any libdrm
> > +# version dependencies in non-driver-specific code should be
> reflected
> > +# in the first entry.
> > +libdrm_version           = '2.4.75'
> > +libdrm_amdgpu_version    = '2.4.89'
> > +libdrm_etnaviv_version   = '2.4.82'
> > +libdrm_freedreno_version = '2.4.82'
> > +libdrm_intel_version     = '2.4.75'
> > +libdrm_nouveau_version   = '2.4.66'
> > +libdrm_radeon_version    = '2.4.71'
> 
> Is there any reason we can't just make these (for example):
> libdrm_radeon_version    = '>= 2.4.71'
> 
> Since that avoids all of the format calls?

Sure. I was trying to only have the actual numbers here, but in hindsight
all these format() calls are a bit ugly.
I'll send a v2 tomorrow.

> 
> [snip]
> 
> Dylan