[Mesa-dev] [PATCH 10/11] vbo: optimize loops in bind_vertex_list(), vbo_exec_bind_arrays()

[Mathias Fröhlich]

Hi Brian,

On Monday, 29 January 2018 19:24:15 CET Brian Paul wrote:
> On 01/27/2018 08:01 AM, Mathias Fröhlich wrote:
> > Hi Brian,
> > 
> > The change should not change the current behavior.
> > Nevertheless the current behavior as well as past your change the code has 
a
> > corner case that will not work correctly.
> 
> Can you elaborate?

If VBO_ATTRIB_POS is in the current code switched off in favour 
VBO_ATTRIB_GENERIC0 then the offsets may get shifted as in the wong sequence 
as the array look only does buffer_offset += node_attrsz[src] *...;
So if the size array position at number 0 is skipped at incrementing the 
buffer_offset variable already the next VBO_NORMAL_ARRAY offset is wrong by 
the unapplied position offset. The generic values are again with the correct 
offset as the positon offset increment was applied then.

> > I do have a hand full of unpublished changes here that will fix that 
potential
> > problem and achieve something similar to what you are doing now with 
different
> > means. So, if you don't mind not applying that one I that saves me from
> > intrusively rebasing my series here.
> 
> Sounds good.
I hope to send a first part for review later today.

best

Mathias