[Mesa-dev] [PATCH] virgl: also remove dimension on indirect.

Gurchetan Singh gurchetansingh at chromium.org
Wed Jan 31 02:04:36 UTC 2018


Any plans to merge this?  This fixes Chrome not starting with Virgl.

Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh at chromium.org>

On Mon, Nov 13, 2017 at 12:53 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This fixes some dEQP tests that generated bad shaders.
>
> Fixes: b6f6ead19 (virgl: drop const dimensions on first block.)
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/virgl/virgl_tgsi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/drivers/virgl/virgl_tgsi.c b/src/gallium/drivers/virgl/virgl_tgsi.c
> index aa483ad..ca05913 100644
> --- a/src/gallium/drivers/virgl/virgl_tgsi.c
> +++ b/src/gallium/drivers/virgl/virgl_tgsi.c
> @@ -76,7 +76,6 @@ virgl_tgsi_transform_instruction(struct tgsi_transform_context *ctx,
>     for (unsigned i = 0; i < inst->Instruction.NumSrcRegs; i++) {
>        if (inst->Src[i].Register.File == TGSI_FILE_CONSTANT &&
>            inst->Src[i].Register.Dimension &&
> -          !inst->Src[i].Register.Indirect &&
>            inst->Src[i].Dimension.Index == 0)
>           inst->Src[i].Register.Dimension = 0;
>     }
> --
> 2.9.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list