[Mesa-dev] [PATCH 3/4] anv/cmd_buffer: make descriptors dirty when emitting base state address

[Iago Toral]

On Sun, 2018-07-01 at 18:32 -0500, Jason Ekstrand wrote:
> 1-3 are R-b me. Should we cc stable?

Yes, I think these should go to stable.

> On June 29, 2018 03:11:00 Iago Toral Quiroga <itoral at igalia.com>
> wrote:
> 
> > Every time we emit a new state base address we will need to re-emit 
> > our
> > binding tables, since they might have been emitted with a different
> > base
> > state adress.
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/intel/vulkan/genX_cmd_buffer.c 
> > b/src/intel/vulkan/genX_cmd_buffer.c
> > index 66d1ef7d786..611311904e6 100644
> > --- a/src/intel/vulkan/genX_cmd_buffer.c
> > +++ b/src/intel/vulkan/genX_cmd_buffer.c
> > @@ -67,6 +67,11 @@ genX(cmd_buffer_emit_state_base_address)(struct 
> > anv_cmd_buffer *cmd_buffer)
> > {
> >    struct anv_device *device = cmd_buffer->device;
> > 
> > +   /* If we are emitting a new state base address we probably need
> > to re-emit
> > +    * binding tables.
> > +    */
> > +   cmd_buffer->state.descriptors_dirty |= ~0;
> > +
> >    /* Emit a render target cache flush.
> >     *
> >     * This isn't documented anywhere in the PRM.  However, it seems
> > to be
> > --
> > 2.14.1
> 
> 
> 
>