[Mesa-dev] [Bug 107090] nir: problem case for loop unrolling

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 3 00:38:03 UTC 2018


Timothy Arceri <t_arceri at yahoo.com.au> changed:

           What    |Removed                     |Added
             Status|NEW                         |NEEDINFO

--- Comment #1 from Timothy Arceri <t_arceri at yahoo.com.au> ---
Was this fixed by the following commit?

author  Timothy Arceri <tarceri at itsqueeze.com>
commit  463f849097193ad20e7622ddd740fd15b96f4277

nir: fix selection of loop terminator when two or more have the same limit
We need to add loop terminators to the list in the order we come
across them otherwise if two or more have the same exit condition
we will select that last one rather than the first one even though
its unreachable.

This fix is for simple unrolls where we only have a single exit
point. When unrolling these type of loops the unreachable
terminators and their unreachable branch are removed prior to
unrolling. Because of the logic change we also switch some
list access in the complex unrolling logic to avoid breakage.

Fixes: 6772a17acc8e ("nir: Add a loop analysis pass")

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180703/656444aa/attachment.html>

More information about the mesa-dev mailing list