[Mesa-dev] [PATCH 11/11] ac: make some fns static

Marek Olšák maraeo at gmail.com
Tue Jul 3 23:13:30 UTC 2018


For patches 9-11:
Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Mon, Jul 2, 2018 at 8:42 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Some of the compiler functions are no longer called outside
> the util file.
> ---
>  src/amd/common/ac_llvm_util.c | 12 ++++++------
>  src/amd/common/ac_llvm_util.h |  7 -------
>  2 files changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c
> index 8deba53c6e7..2722701ecb8 100644
> --- a/src/amd/common/ac_llvm_util.c
> +++ b/src/amd/common/ac_llvm_util.c
> @@ -67,7 +67,7 @@ void ac_init_llvm_once(void)
>         call_once(&ac_init_llvm_target_once_flag, ac_init_llvm_target);
>  }
>
> -LLVMTargetRef ac_get_llvm_target(const char *triple)
> +static LLVMTargetRef ac_get_llvm_target(const char *triple)
>  {
>         LLVMTargetRef target = NULL;
>         char *err_message = NULL;
> @@ -133,9 +133,9 @@ const char *ac_get_llvm_processor_name(enum radeon_family family)
>         }
>  }
>
> -LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family,
> -                                             enum ac_target_machine_options tm_options,
> -                                             const char **out_triple)
> +static LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family,
> +                                                    enum ac_target_machine_options tm_options,
> +                                                    const char **out_triple)
>  {
>         assert(family >= CHIP_TAHITI);
>         char features[256];
> @@ -165,8 +165,8 @@ LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family,
>         return tm;
>  }
>
> -LLVMPassManagerRef ac_init_passmgr(LLVMTargetLibraryInfoRef target_library_info,
> -                                  bool check_ir)
> +static LLVMPassManagerRef ac_init_passmgr(LLVMTargetLibraryInfoRef target_library_info,
> +                                         bool check_ir)
>  {
>         LLVMPassManagerRef passmgr = LLVMCreatePassManager();
>         if (!passmgr)
> diff --git a/src/amd/common/ac_llvm_util.h b/src/amd/common/ac_llvm_util.h
> index 8f0e0f018ea..c6ee537b74c 100644
> --- a/src/amd/common/ac_llvm_util.h
> +++ b/src/amd/common/ac_llvm_util.h
> @@ -76,11 +76,6 @@ struct ac_llvm_compiler {
>  };
>
>  const char *ac_get_llvm_processor_name(enum radeon_family family);
> -LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family,
> -                                             enum ac_target_machine_options tm_options,
> -                                             const char **out_triple);
> -
> -LLVMTargetRef ac_get_llvm_target(const char *triple);
>  void ac_add_attr_dereferenceable(LLVMValueRef val, uint64_t bytes);
>  bool ac_is_sgpr_param(LLVMValueRef param);
>  void ac_add_function_attr(LLVMContextRef ctx, LLVMValueRef function,
> @@ -119,8 +114,6 @@ ac_get_store_intr_attribs(bool writeonly_memory)
>  unsigned
>  ac_count_scratch_private_memory(LLVMValueRef function);
>
> -LLVMPassManagerRef ac_init_passmgr(LLVMTargetLibraryInfoRef target_library_info,
> -                                  bool check_ir);
>  LLVMTargetLibraryInfoRef ac_create_target_library_info(const char *triple);
>  void ac_dispose_target_library_info(LLVMTargetLibraryInfoRef library_info);
>  void ac_init_llvm_once(void);
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list