[Mesa-dev] [PATCH 20/26] python: Open file in binary mode

Mathieu Bridon bochecha at daitauha.fr
Thu Jul 5 13:17:51 UTC 2018

The XML parser wants byte strings, not unicode strings.

In both Python 2 and 3, opening a file without specifying the mode will
open it for reading in text mode ('r').

On Python 2, the read() method of the file object will return byte
strings, while on Python 3 it will return unicode strings.

Explicitly specifying the binary mode ('rb') makes the behaviour
identical in both Python 2 and 3, returning what the XML parser

Signed-off-by: Mathieu Bridon <bochecha at daitauha.fr>
 src/intel/genxml/gen_bits_header.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py
index e31e9ff103..dcd6ccb7d9 100644
--- a/src/intel/genxml/gen_bits_header.py
+++ b/src/intel/genxml/gen_bits_header.py
@@ -282,7 +282,7 @@ class XmlParser(object):
         self.container = None
     def parse(self, filename):
-        with open(filename) as f:
+        with open(filename, 'rb') as f:
     def start_element(self, name, attrs):

More information about the mesa-dev mailing list