[Mesa-dev] [PATCH] intel: tools: fix build on old systems

[Emil Velikov]

On 5 July 2018 at 16:33, Matt Turner <mattst88 at gmail.com> wrote:
> On Thu, Jul 5, 2018 at 7:42 AM Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>>
>> Older system might not have support for memfd_create at the kernel
>> level. There we won't be able to use aubinator.
>>
>> We also initially tried to workaround some libc having the
>> memfd_create syscall number defined, but not the memfd_create()
>> function.
>>
>> This change fixes the broken build on the travis CI by only compiling
>> aubinator if memfd_create() is available as part of the libc.
>
> memfd_create() was added in glibc-2.27. I think that's too new to rely
> on. I know aubinator is a developer tool, but I don't think most
> developers have glibc 2.27 yet.
>
> I'd suggest we rename our "memfd_create" functions to avoid the clash
> with glibc-2.27+ and just use them regardless.
>
I'm a fan on this. Less code and build system magic is always great.

I'd imagine the man page meant to say "linux/memfd.h" instead of "sys/memfd.h"

-Emil