[Mesa-dev] [PATCH 22/26] python: Use open(), not file()
Dylan Baker
dylan at pnwbakers.com
Thu Jul 5 16:39:10 UTC 2018
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
Quoting Mathieu Bridon (2018-07-05 06:17:53)
> The latter is a constructor for file objects, but when actually opening
> a file, using the former is more idiomatic.
>
> In addition, file() is not a builtin any more in Python 3, so this makes
> the script compatible with both Python 2 and Python 3.
>
> Signed-off-by: Mathieu Bridon <bochecha at daitauha.fr>
> ---
> src/util/xmlpool/gen_xmlpool.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py
> index 886c1854f3..b0db183854 100644
> --- a/src/util/xmlpool/gen_xmlpool.py
> +++ b/src/util/xmlpool/gen_xmlpool.py
> @@ -168,7 +168,7 @@ print("/***********************************************************************\
>
> # Process the options template and generate options.h with all
> # translations.
> -template = file (template_header_path, "r")
> +template = open (template_header_path, "r")
> descMatches = []
> for line in template:
> if len(descMatches) > 0:
> @@ -199,6 +199,8 @@ for line in template:
> else:
> print(line, end='')
>
> +template.close()
> +
> if len(descMatches) > 0:
> sys.stderr.write ("Warning: unterminated description at end of file.\n")
> expandMatches (descMatches, translations)
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180705/b0392b9e/attachment.sig>
More information about the mesa-dev
mailing list