[Mesa-dev] [PATCH] st/nir: Disable varying packing when doing transform feedback.

[Eric Anholt]

Timothy Arceri <t_arceri at yahoo.com.au> writes:

> On 03/07/18 05:51, Eric Anholt wrote:
>
>> Eric Anholt <eric at anholt.net> writes:
>>
>>> [ Unknown signature status ]
>>> Timothy Arceri <tarceri at itsqueeze.com> writes:
>>>
>>>> nir_compact_varyings() is meant to skip over varyings used by xfb:
>>>>
>>>>            /* We can't repack xfb varyings. */
>>>>            if (var->data.always_active_io)
>>>>               continue;
>>>>
>>>> Any idea why that isn't working in this case?
>>> Looks like GLSL IR has that flag wrong.  points.7 has v_var6,7,8,9
>>> transform feedback output, but the IR says:
>> [...]
>>
>> Any feedback on this?  This is my remaining TF issue for V3D.
> Hmm. I think this still gets messed up because if packing the non-xfb 
> varyings results in freeing up a location then st_nir_assign_var_locations()
> will end up assigning a new location for the xfb varyings.
>
> I think your patch to disable for xfb is the easiest way to work around 
> this for now. I still hope we might one day have a full NIR GLSL linker 
> to replace GLSL IR but my hopes of ever seeing one are slowly fading.
>
> Anyway for this patch:
>
> Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

Thanks!

I do wish for better linking as well, but state_tracker's program
handling is so convoluted that I can only ever hold a fraction of it in
my head at a time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180705/cd06751b/attachment.sig>