[Mesa-dev] [PATCH 1.5/3] nir: Add a nir_instr_move helper

Caio Marcelo de Oliveira Filho caio.oliveira at intel.com
Thu Jul 5 22:59:31 UTC 2018


> > Should we also consider the block-based cursor options here? Moving
> > the first instruction of a block before that block
> > (nir_cursor_before_block), etc.
> >
> 
> That should be fine as-is as nir_instr_insert should do the right thing.
> The reason the cursor.instr == instr case is a problem is because you can't
> insert an instruction relative to itself.

Got it.


Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>



More information about the mesa-dev mailing list