[Mesa-dev] [PATCH 3/3] mesa: verify MaxVertexAttribStride for GLES 3.1

[Marek Olšák]

For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Jul 6, 2018 at 6:03 AM, Erik Faye-Lund
<erik.faye-lund at collabora.com> wrote:
> The OpenGL 3.1 specification, table Table 20.41 ("Implementation
> Dependent Values"), defines the minimum-maximum value for
> MAX_VERTEX_ATTRIB_STRIDE to be 2048.
>
> So we shouldn't enable OpenGL ES 3.1 on implementations where this
> isn't the case. Let's add a check for this
>
> Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> ---
>  src/mesa/main/version.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
> index 0b0d5b79d6..58e68b4772 100644
> --- a/src/mesa/main/version.c
> +++ b/src/mesa/main/version.c
> @@ -530,6 +530,7 @@ compute_version_es2(const struct gl_extensions *extensions,
>     const bool es31_compute_shader =
>        consts->MaxComputeWorkGroupInvocations >= 128;
>     const bool ver_3_1 = (ver_3_0 &&
> +                         consts->MaxVertexAttribStride >= 2048 &&
>                           extensions->ARB_arrays_of_arrays &&
>                           es31_compute_shader &&
>                           extensions->ARB_draw_indirect &&
> --
> 2.18.0.rc2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev