[Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

[Ian Romanick]

Assuming the concerns about patch 1 are resolved, patches 2 and 3 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 07/06/2018 03:03 AM, Erik Faye-Lund wrote:
> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum
> vertex attrib stride to be at least 2048. If this isn't
> the case, we shouldn't expose these API versions.
> 
> Unfortunately, the r600 driver only supports 2047. To
> avoid regressions in the supported GL version, the
> first patch modifies the returned value.
> 
> I'm not sure if that last one is a good idea or not, as
> it's strictly speaking non-conformant. But applications
> won't expect GL errors generated when using strides of
> 2048 either, which is what currently happens.
> 
> The initial motivation for this patch-series is to avoid
> exposing a too high spec version in virgl and then get
> dEQP failures when running on old hardware. The virgl
> specific bits are being sent separately, because they
> depend on some other not-yet-upstream things ATM.
> 
> Thoughts?
> 
> Erik Faye-Lund (3):
>   r600: report incorrect max-vertex-attrib for GL 4.4
>   mesa: verify MaxVertexAttribStride for GL 4.4
>   mesa: verify MaxVertexAttribStride for GLES 3.1
> 
>  src/gallium/drivers/r600/r600_pipe.c | 3 ++-
>  src/mesa/main/version.c              | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
>