[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Jul 7 19:27:24 UTC 2018


--- Comment #1 from Roland Scheidegger <sroland at vmware.com> ---
(In reply to Bernhard Rosenkraenzer from comment #0)
> createInstructionSimplifierPass() has been removed in LLVM. This is used in
> a few places in SWR; looks like this can safely be removed because it is
> always preceded by createInstructionCombiningPass() which seems to be a
> superset of what createInstructionSimplifierPass() used to do.
> Fixing this just unmasks another problem though -
> Intrinsic::x86_fma_vfmadd_ps_256 is gone. Not sure how to replace that
> properly.

I believe the caller doesn't actually care if it's fma or fmul/fadd combo. In
this case it should just be replaced with llvm.fmuladd - this works will all
(supported by swr) llvm versions, and you don't need to distinguish in the
caller if the cpu supports fma or not, llvm will automatically emit either fma
or fmul/fadd.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180707/e4438dde/attachment.html>

More information about the mesa-dev mailing list