[Mesa-dev] [PATCH] nir: delete not needed for reinserted nir_cf_list

[Jason Ekstrand]

Yeah, I think this is probably better.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Thu, Jul 5, 2018 at 5:50 PM Caio Marcelo de Oliveira Filho <
caio.oliveira at intel.com> wrote:

> It wasn't causing problems since there's nothing to delete, but better
> be consistent with the rest of existing codebase.
> ---
>  src/compiler/nir/nir_opt_if.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/nir/nir_opt_if.c
> index ec5bf1c9027..a52de120ad6 100644
> --- a/src/compiler/nir/nir_opt_if.c
> +++ b/src/compiler/nir/nir_opt_if.c
> @@ -279,7 +279,6 @@ opt_if_simplification(nir_builder *b, nir_if *nif)
>     nir_cf_extract(&tmp, nir_before_cf_list(&nif->else_list),
>                          nir_after_cf_list(&nif->else_list));
>     nir_cf_reinsert(&tmp, nir_before_cf_list(&nif->then_list));
> -   nir_cf_delete(&tmp);
>
>     return true;
>  }
> @@ -345,7 +344,6 @@ opt_if_loop_terminator(nir_if *nif)
>     nir_cf_extract(&tmp, nir_before_block(first_continue_from_blk),
>                          nir_after_block(continue_from_blk));
>     nir_cf_reinsert(&tmp, nir_after_cf_node(&nif->cf_node));
> -   nir_cf_delete(&tmp);
>
>     return true;
>  }
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180709/ae937e17/attachment.html>