[Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

David Airlie airlied at redhat.com
Tue Jul 10 06:57:54 UTC 2018

On Tue, Jul 10, 2018 at 4:44 PM, Gert Wollny <gert.wollny at collabora.com>

> Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie:
> >
> > Just FYI in future please don't push mesa patches until the renderer
> > side patch has landed, this is to avoid the abi accidentally
> > diverging around the caps.
> Sure, I'll keep that in mind, and sorry for rushing to push this.
> However, this actually points to a bigger problem: Given that the
> mesa/virgl driver is completely separate from the host virglrenderer,
> how do we ensure in a real world application that host and guest agree
> on the abi? There is this 'version' in the
> vrend_renderer_fill_caps_common and the 'max_version' in the caps, but
> the first one is not used at all, and the second is not used beyond
> signalling the availability of caps set 2. Maybe we should define some
> algorithm to bump that latter number so the client can see what values
> in the caps were actually filled by the host?
We already deal with ABI at runtime. The problem is diverging the
virgl_hw.h file.

One copy of that file needs to be master and we only add to the end of the
caps v2
struct, but the version that is the master copy is the one in
virglrenderer. So if
we end up pushing patches to mesa first, and someone pushes another change
to virglrenderer we get incompatible overlap.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180710/5f57ec48/attachment.html>

More information about the mesa-dev mailing list