[Mesa-dev] [PATCH] gallium/u_transfer_helper: Initialize the stride of MSAA maps.

Rob Clark robdclark at gmail.com
Tue Jul 10 12:03:01 UTC 2018


On Tue, Jul 10, 2018 at 2:07 AM, Eric Anholt <eric at anholt.net> wrote:
> We just never set the value that was returned for MSAA mappings (directly
> reading back an MSAA framebuffer).  Since we're handing back ss_map, it
> should be ss_map's stride from our nested transfer.
>
> Fixes piglit /home/anholt/src/piglit/bin/fbo-depthstencil -samples=4
> casees.

nit: s/casees/cases/

Reviewed-by: Rob Clark <robdclark at gmail.com>


> ---
>  src/gallium/auxiliary/util/u_transfer_helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c b/src/gallium/auxiliary/util/u_transfer_helper.c
> index fd8a5c3a0895..df67f8288523 100644
> --- a/src/gallium/auxiliary/util/u_transfer_helper.c
> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c
> @@ -218,6 +218,7 @@ transfer_map_msaa(struct pipe_context *pctx,
>        return NULL;
>     }
>
> +   ptrans->stride = trans->trans->stride;
>     *pptrans = ptrans;
>     return ss_map;
>  }
> --
> 2.18.0
>


More information about the mesa-dev mailing list