[Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

Olivier Fourdan fourdan at gmail.com
Tue Jul 10 17:04:58 UTC 2018


Hi,

On Tue, 10 Jul 2018 at 18:56, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> Ugh... not so good.  According to Oliver on the bug, this just make the assert go away and doesn't actually fix anything.  Likely this is needed but not sufficient.

Well, maybe not even needed, at least in my case I don't hit that
assert() with the current Mesa code (from either master and 18.1),
I've just seen that happening with past commits while doing the
bisection in git... So adding this now wouldn't help with bisection
(again, in my case, not sure about others).

All I meant pointing at this assert() failure is that it breaks the
bisection in git as I am unable to tell if the rendering is correct or
not as it makes the test program abort.

Cheers,
Olivier


More information about the mesa-dev mailing list