[Mesa-dev] [PATCH 5/5] radv: simplify the logic in radv_set_descriptor_set()

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

for the series.

On Tue, Jul 10, 2018 at 4:13 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Now that 'set' can't be NULL because the meta operations no
> longer bind a NULL descriptor, the logic can be simplified
> a little bit.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 11f4c29db4..e85a9d7c98 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -518,10 +518,8 @@ void radv_set_descriptor_set(struct radv_cmd_buffer *cmd_buffer,
>                 radv_get_descriptors_state(cmd_buffer, bind_point);
>
>         descriptors_state->sets[idx] = set;
> -       if (set)
> -               descriptors_state->valid |= (1u << idx);
> -       else
> -               descriptors_state->valid &= ~(1u << idx);
> +
> +       descriptors_state->valid |= (1u << idx); /* active descriptors */
>         descriptors_state->dirty |= (1u << idx);
>  }
>
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev