[Mesa-dev] [AppVeyor] mesa master #8296 failed

[Roland Scheidegger]

Am 13.07.2018 um 23:07 schrieb AppVeyor:
> 
>   Build mesa 8296 failed
>   <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa%2Fbuild%2F8296&data=02%7C01%7Csroland%40vmware.com%7Cc05cbe76060a40b69e3a08d5e9049c28%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636671128368939176&sdata=WBwrZjXFQauU%2Bg89AVPR7D4WxTesij3C0ULYsT4%2FKms%3D&reserved=0>
> 
> Commit a3150c1d06 by Jason Ekstrand <mailto:jason at jlekstrand.net> on
> 7/13/2018 1:23 AM:
> nir/lower_tex: Use nir_format_srgb_to_linear\n\nA while ago, we added a
> bunch of format conversion helpers; we should\nuse them instead of
> hand-rolling sRGB conversions.\n\nReviewed-by: Eric Anholt
> <eric at anholt.net>
> 

c:\projects\mesa\src\compiler\nir\nir_format_convert.h(70): warning
C4146: unary minus operator applied to unsigned type, result still unsigned
c:\projects\mesa\src\compiler\nir\nir_format_convert.h(124): error
C2059: syntax error: '}'
scons: *** [build\windows-x86-debug\compiler\nir\nir_lower_tex.obj] Error 2
scons: building terminated because of errors.

I think this is by far the most often issue causing build breakage, so
everybody repeat after me:
empty initializer braces are not valid C
empty initializer braces are not valid C
empty initializer braces are not valid C

:-).

(Ok it's not the only non-c99 compliant feature used, but this one
really trips up msvc.)

Roland