[Mesa-dev] [PATCH v4 0/4] r600: Fix array texture slice index evaluation

Gert Wollny gw.fossdev at gmail.com
Mon Jul 16 08:26:16 UTC 2018

From: Gert Wollny <gert.wollny at collabora.com>

Hello Roland, Dave, and everybody else, 

this is a 90% rewrite of the earlier series. 

- I removed the changes to the texture state and handle everything in the 
  shader. Since this was needed for cube arrays anyway, and also taking Rolands
  concern into account I thought it is best to do this for the other arrays as 
- I've identified to the root cause why sb was having problems with the
  GATHER_O instruction, and reworked the code to make sure that the related
  texture instructions are all emitted in one CF clause, This is also required
  for the SET_GRADIENT instructions. 
- I've also correct the array index for cube textures now.

I didn't see any changes with 

  piglit run gpu -t texture -t gather -t formats    

Many thanks for reviewing, 

Gert Wollny (4):
  r600: Delay emission of texture gradients and lookup offsets
  r600: Add extra function to evaluate array index
  r600: correct texture offset for array index lookup
  r600: Correct evaluation of cube array index and face

 src/gallium/drivers/r600/r600_shader.c | 187 ++++++++++++++++++++++++---------
 1 file changed, 140 insertions(+), 47 deletions(-)


More information about the mesa-dev mailing list