[Mesa-dev] [PATCH 05/11] anv: avoid warning when switching in VkStructureType

Caio Marcelo de Oliveira Filho caio.oliveira at intel.com
Mon Jul 16 22:36:37 UTC 2018

When one of the cases is not part of the enum, the compilar complains:

../../src/intel/vulkan/anv_formats.c: In function ‘anv_GetPhysicalDeviceFormatProperties2’:
../../src/intel/vulkan/anv_formats.c:728:7: warning: case value ‘1000001004’ not in enumerated type ‘VkStructureType’ {aka ‘enum VkStructureType’} [-Wswitch]

Given the switch has an "default:" case, we don't lose anything by
switching on the unsigned value to avoid the warning.
 src/intel/vulkan/anv_formats.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 0c5b8d3a2c8..815b320a826 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -724,7 +724,8 @@ void anv_GetPhysicalDeviceFormatProperties2(
    vk_foreach_struct(ext, pFormatProperties->pNext) {
-      switch (ext->sType) {
+      /* Use unsigned since some cases are not in the VkStructureType enum. */
+      switch ((unsigned)ext->sType) {
          get_wsi_format_modifier_properties_list(physical_device, format,
                                                  (void *)ext);

More information about the mesa-dev mailing list