[Mesa-dev] [PATCH 5/5] radv: Enable binning and dfsm by default on Raven.

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Jul 17 07:17:21 UTC 2018



On 07/14/2018 02:28 PM, Bas Nieuwenhuizen wrote:
> Seems like it increases performance by 2-3% for some demos and games.
> ---
>   src/amd/vulkan/radv_device.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 8274b6ea09..71635ded49 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1502,10 +1502,12 @@ VkResult radv_CreateDevice(
>   	}
>   
>   	device->pbb_allowed = device->physical_device->rad_info.chip_class >= GFX9 &&
> -	                      (device->instance->perftest_flags & RADV_PERFTEST_BINNING);
> +			((device->instance->perftest_flags & RADV_PERFTEST_BINNING) ||
> +			 device->physical_device->rad_info.family == CHIP_RAVEN);
>   
>   	/* Disabled and not implemented for now. */

You might want to remove that comment.

Patches 1-3 and 5 are:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

> -	device->dfsm_allowed = device->pbb_allowed && false;
> +	device->dfsm_allowed = device->pbb_allowed &&
> +	                       device->physical_device->rad_info.family == CHIP_RAVEN;
>   
>   #ifdef ANDROID
>   	device->always_use_syncobj = device->physical_device->rad_info.has_syncobj_wait_for_submit;
> 


More information about the mesa-dev mailing list