[Mesa-dev] [PATCH 4/5] radv: Always set disable zpass increment bit when possible.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jul 17 09:06:13 UTC 2018


Aligning with AMDVLK on GFX9. I don't think it changes much.

On Tue, Jul 17, 2018 at 9:15 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Why do we need that? Are you sure it's correct?
>
>
> On 07/14/2018 02:28 PM, Bas Nieuwenhuizen wrote:
>>
>> When no occlusion queries are active even if out of order is enabled.
>> ---
>>   src/amd/vulkan/radv_cmd_buffer.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/src/amd/vulkan/radv_cmd_buffer.c
>> b/src/amd/vulkan/radv_cmd_buffer.c
>> index b6729e40b4..78838d9939 100644
>> --- a/src/amd/vulkan/radv_cmd_buffer.c
>> +++ b/src/amd/vulkan/radv_cmd_buffer.c
>> @@ -1561,10 +1561,8 @@ void radv_set_db_count_control(struct
>> radv_cmd_buffer *cmd_buffer)
>>
>> R_028A4C_PA_SC_MODE_CNTL_1,
>>                                                        pa_sc_mode_cntl_1);
>>                         }
>> -                       db_count_control = 0;
>> -               } else {
>> -                       db_count_control =
>> S_028004_ZPASS_INCREMENT_DISABLE(1);
>>                 }
>> +               db_count_control = S_028004_ZPASS_INCREMENT_DISABLE(1);
>>         } else {
>>                 const struct radv_subpass *subpass =
>> cmd_buffer->state.subpass;
>>                 uint32_t sample_rate = subpass ?
>> util_logbase2(subpass->max_sample_count) : 0;
>>
>


More information about the mesa-dev mailing list