[Mesa-dev] [PATCH] anv: fix assert in anv_CmdBindDescriptorSets()

[Lionel Landwerlin]

On 17/07/18 10:48, Samuel Iglesias Gonsálvez wrote:
> The assert is checking that we are not binding more descriptor sets
> than the supported by the driver. When binding the descriptor set
> number MAX_SETS-1, it was breaking the assert because
> descriptorSetCount = 1.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Oops :(
This goes back so far, we can't really pin a particular stable version.

Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

> ---
>   src/intel/vulkan/anv_cmd_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c
> index 201b73ad45a..8ef71b0ed9c 100644
> --- a/src/intel/vulkan/anv_cmd_buffer.c
> +++ b/src/intel/vulkan/anv_cmd_buffer.c
> @@ -613,7 +613,7 @@ void anv_CmdBindDescriptorSets(
>      ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
>      ANV_FROM_HANDLE(anv_pipeline_layout, layout, _layout);
>   
> -   assert(firstSet + descriptorSetCount < MAX_SETS);
> +   assert(firstSet + descriptorSetCount <= MAX_SETS);
>   
>      for (uint32_t i = 0; i < descriptorSetCount; i++) {
>         ANV_FROM_HANDLE(anv_descriptor_set, set, pDescriptorSets[i]);