[Mesa-dev] [PATCH] radv: reduce number of CB/DB meta flushes for VK_ACCESS_TRANSFER_WRITE_BIT

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Jul 13, 2018 at 5:35 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> If we know that the given image doesn't have any metadata,
> we don't need to flush.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index e066b160b6..3646c1ae89 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1966,8 +1966,15 @@ radv_src_access_flush(struct radv_cmd_buffer *cmd_buffer,
>                       VkAccessFlags src_flags,
>                       struct radv_image *image)
>  {
> +       bool flush_CB_meta = true, flush_DB_meta = true;
>         enum radv_cmd_flush_bits flush_bits = 0;
>         uint32_t b;
> +
> +       if (image && !radv_image_has_CB_metadata(image))
> +               flush_CB_meta = false;
> +       if (image && !radv_image_has_htile(image))
> +               flush_DB_meta = false;
> +
>         for_each_bit(b, src_flags) {
>                 switch ((VkAccessFlagBits)(1 << b)) {
>                 case VK_ACCESS_SHADER_WRITE_BIT:
> @@ -1975,22 +1982,23 @@ radv_src_access_flush(struct radv_cmd_buffer *cmd_buffer,
>                         break;
>                 case VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT:
>                         flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB;
> -                       if (!image || (image && radv_image_has_CB_metadata(image))) {
> +                       if (flush_CB_meta)
>                                 flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;
> -                       }
>                         break;
>                 case VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT:
>                         flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_DB;
> -                       if (!image || (image && radv_image_has_htile(image))) {
> +                       if (flush_DB_meta)
>                                 flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_DB_META;
> -                       }
>                         break;
>                 case VK_ACCESS_TRANSFER_WRITE_BIT:
>                         flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB |
> -                                     RADV_CMD_FLAG_FLUSH_AND_INV_CB_META |
>                                       RADV_CMD_FLAG_FLUSH_AND_INV_DB |
> -                                     RADV_CMD_FLAG_FLUSH_AND_INV_DB_META |
>                                       RADV_CMD_FLAG_INV_GLOBAL_L2;
> +
> +                       if (flush_CB_meta)
> +                               flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;
> +                       if (flush_DB_meta)
> +                               flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_DB_META;
>                         break;
>                 default:
>                         break;
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev