[Mesa-dev] [PATCH v2 2/2] nv50/ir: move LateAlgebraicOpt back to right after ConstantFolding

Karol Herbst kherbst at redhat.com
Tue Jul 17 11:20:33 UTC 2018


can it be moved after Split64BitOpPreRA? The problem we want to fix
here is that LoadPropagation can potentially do some optimizations
after running LateAlgebraicOpt.

On Tue, Jun 12, 2018 at 3:30 PM, Rhys Perry <pendingchaos02 at gmail.com> wrote:
> Reverts 3072bbe ("nv50/ir: move LateAlgebraicOpt to the very end") since
> SHLADD is now handled in IndirectPropagation.
>
> total instructions in shared programs : 5264804 -> 5256901 (-0.15%)
> total gprs used in shared programs    : 624341 -> 624328 (-0.00%)
> total shared used in shared programs  : 360704 -> 360704 (0.00%)
> total local used in shared programs   : 20952 -> 20952 (0.00%)
>
>                 local     shared        gpr       inst      bytes
>     helped           0           0          69        1993        1993
>       hurt           0           0          52          32          32
>
> Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> index 83fb15ca34..4d0589214d 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> @@ -3809,11 +3809,11 @@ Program::optimizeSSA(int level)
>     RUN_PASS(2, AlgebraicOpt, run);
>     RUN_PASS(2, ModifierFolding, run); // before load propagation -> less checks
>     RUN_PASS(1, ConstantFolding, foldAll);
> +   RUN_PASS(2, LateAlgebraicOpt, run);
>     RUN_PASS(1, Split64BitOpPreRA, run);
>     RUN_PASS(1, LoadPropagation, run);
>     RUN_PASS(1, IndirectPropagation, run);
>     RUN_PASS(2, MemoryOpt, run);
> -   RUN_PASS(2, LateAlgebraicOpt, run);
>     RUN_PASS(2, LocalCSE, run);
>     RUN_PASS(0, DeadCodeElim, buryAll);
>
> --
> 2.14.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list