[Mesa-dev] [PATCH v5 0/3] r600: Fix array texture slice index evaluation

Gert Wollny gw.fossdev at gmail.com
Tue Jul 17 17:04:06 UTC 2018

From: Gert Wollny <gert.wollny at collabora.com>

Dear all, 

v5: replace ADD+0.5/FLOOR by RNDNE as suggested by Ilia Mirkin.

post from v4 follows: 

This is a 90% rewrite of the earlier series. 

- I removed the changes to the texture state and handle everything in the 
  shader. Since this was needed for cube arrays anyway, and also taking Rolands
  concern into account I thought it is best to do this for the other arrays as 
- I've identified to the root cause why sb was having problems with the
  GATHER_O instruction, and reworked the code to make sure that the related
  texture instructions are all emitted in one CF clause, This is also required
  for the SET_GRADIENT instructions. 
- I've also correct the array index for cube textures now.

I didn't see any changes with 

  piglit run gpu -t texture -t gather -t formats    

thanks for reviewing, 

Gert Wollny (3):
  r600: Delay emission of texture gradients and lookup offsets
  r600: correct texture offset for array index lookup
  r600: Correct evaluation of cube array index and face

 src/gallium/drivers/r600/r600_shader.c | 162 +++++++++++++++++++++++----------
 1 file changed, 115 insertions(+), 47 deletions(-)


More information about the mesa-dev mailing list