[Mesa-dev] [PATCH] glsl: Allow ES2 function parameters to be hidden by variable declarations.

[Eric Anholt]

Ilia Mirkin <imirkin at alum.mit.edu> writes:

> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt <eric at anholt.net> wrote:
>> Ilia Mirkin <imirkin at alum.mit.edu> writes:
>>
>>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
>>> drive-by comment, not a real review, sorry]
>>
>> That doesn't respect the version overrides and such that is_version
>> handles.
>
> Under what circumstance would state->es_shader != state->is_version(0,
> 100)? I can't think of one, but perhaps I'm just insufficiently
> creative.

So you want to replace just the 100 call and leave the !300?  I guess
that would be logically equivalent, but I'm not interested in painting
the bikeshed that color.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180717/95102a04/attachment.sig>