[Mesa-dev] [PATCH] gallium: surface remove width/height removal comment

Marek Olšák maraeo at gmail.com
Wed Jul 18 17:53:09 UTC 2018

On Wed, Jul 18, 2018 at 1:46 PM, Roland Scheidegger <sroland at vmware.com> wrote:
> Am 18.07.2018 um 19:29 schrieb Marek Olšák:
>> On Tue, Jul 17, 2018 at 9:44 AM, Roland Scheidegger <sroland at vmware.com> wrote:
>>> Initially, width/height were actually needed because not all
>>> pipe_surface objects were backed by pipe_resource objects (that was ages
>>> ago...). Hence the comment when that was fixed, since it was always
>>> actually possible to derive this from the resource (but a bit too
>>> complex to change all the code...).
>>> Are there now situations when you can't figure this out from the
>>> resource? Or do you think it's actually useful as a convenience member?
>> It's useful and it would complicated to remove.
> Alright. I was really just more wondering if the values couldn't be
> recalculated always nowadays for some reason. I'm ok with removing the
> comment, even if it's just convenience members.

They can be recalculated, but too many drivers and u_blitter already
rely on the variables and u_blitter expects different values for
blitting compressed textures as integer.


More information about the mesa-dev mailing list