[Mesa-dev] [PATCH] intel/tools: fix segfault with intel_dump_gpu

[Lionel Landwerlin]

Hey Jordan,

I have patch that remove this for loop, reviewed by Jason.
Landing it right now, that should fix this problem.

Thanks,

-
Lionel

On 19/07/18 09:52, Jordan Justen wrote:
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Fixes: 0a457d987ee "intel/tools: Refactor aub dumping to remove singletons"
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>   src/intel/tools/intel_dump_gpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/tools/intel_dump_gpu.c b/src/intel/tools/intel_dump_gpu.c
> index 6d2c4b7f983..e0ff1245925 100644
> --- a/src/intel/tools/intel_dump_gpu.c
> +++ b/src/intel/tools/intel_dump_gpu.c
> @@ -301,7 +301,7 @@ dump_execbuffer2(int fd, struct drm_i915_gem_execbuffer2 *execbuffer2)
>      }
>   
>      for (int i = 0; i < ARRAY_SIZE(files); i++) {
> -      if (files[i] != NULL)
> +      if (files[i] == NULL)
>            continue;
>   
>         aub_write_exec(&aubs[i],