[Mesa-dev] [PATCH] radv: don't flush DB before subpass FS resolves

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Jul 20 13:23:31 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Jul 20, 2018 at 3:07 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> That shouldn't be needed because the DB state is invalid.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_meta_resolve_fs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/radv_meta_resolve_fs.c
> index b652f12ac4..2a0577d9c4 100644
> --- a/src/amd/vulkan/radv_meta_resolve_fs.c
> +++ b/src/amd/vulkan/radv_meta_resolve_fs.c
> @@ -587,8 +587,7 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
>         /* Resolves happen before the end-of-subpass barriers get executed,
>          * so we have to make the attachment shader-readable */
>         barrier.src_stage_mask = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT;
> -       barrier.src_access_mask = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT |
> -                                 VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
> +       barrier.src_access_mask = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT;
>         barrier.dst_access_mask = VK_ACCESS_INPUT_ATTACHMENT_READ_BIT;
>         radv_subpass_barrier(cmd_buffer, &barrier);
>
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list